Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to add/remove projects from the UI #10

Closed
haroon-sheikh opened this issue Sep 27, 2019 · 10 comments · Fixed by #12
Closed

Ability to add/remove projects from the UI #10

haroon-sheikh opened this issue Sep 27, 2019 · 10 comments · Fixed by #12
Labels
enhancement New feature or request hacktoberfest

Comments

@haroon-sheikh
Copy link
Collaborator

Currently, the app shows a list of projects based on flat json file.

This is to allow adding and removing of projects using the UI.
@haroon-sheikh haroon-sheikh added enhancement New feature or request hacktoberfest labels Sep 27, 2019
@haroon-sheikh haroon-sheikh changed the title Ability to add remove tests from the UI Ability to add/remove projects from the UI Sep 27, 2019
@Prateek93a
Copy link
Contributor

Can I work on this for the Hacktoberfest contest?

@haroon-sheikh
Copy link
Collaborator Author

@Prateek93a Go ahead mate.

@Prateek93a
Copy link
Contributor

@haroon-sheikh Thanks

@Prateek93a
Copy link
Contributor

@haroon-sheikh Sir, how would you like the add project feature to be? Should there be a search button to search for the project and add them? Or should there be a dropdown to select the projects we want to see?

@haroon-sheikh
Copy link
Collaborator Author

@Prateek93a To search for the project from github and (if exists) add to the list of projects to show the commit status.

@Prateek93a
Copy link
Contributor

@haroon-sheikh Ok

@Prateek93a
Copy link
Contributor

@haroon-sheikh Sir, just wanted to confirm, that after adding or removing the repos, should the changes be made in the json file as well, or only the display should change?

@haroon-sheikh
Copy link
Collaborator Author

display is enough, the json is just a list of default projects.

@Prateek93a
Copy link
Contributor

@haroon-sheikh Ok

@Prateek93a
Copy link
Contributor

@haroon-sheikh I have made the PR, sorry I did not reference the issue along with it.

@Prateek93a Prateek93a mentioned this issue Sep 30, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ability to add and remove projects from the list
2 participants
@haroon-sheikh @Prateek93a