Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Max allowed packet bytes error #35

Open
siv2r opened this issue Feb 10, 2021 · 11 comments · Fixed by #38
Open

Max allowed packet bytes error #35

siv2r opened this issue Feb 10, 2021 · 11 comments · Fixed by #38
Labels
bug Something isn't working cakewalk Easy to implement good first issue Good for newcomers hacktoberfest For Hacktoberfest 2021 urgent

Comments

@siv2r
Copy link
Owner

siv2r commented Feb 10, 2021

Users can upload file size up to 2MB but the default SQL insertions for BLOB type is 1MB.
Therefore error occurs when the user uploads a filesize between 1 MB - 2 MB.

Possible soln:
Limit the file size to 1MB instead of 2MB in jQuery form validation.

@siv2r siv2r added bug Something isn't working good first issue Good for newcomers cakewalk Easy to implement labels Feb 10, 2021
@siv2r siv2r assigned siv2r and unassigned siv2r Feb 10, 2021
@siv2r siv2r changed the title Max allowed packet bytest erro Max allowed packet bytest error Feb 10, 2021
@siv2r siv2r added the urgent label Feb 11, 2021
@96RadhikaJadhav
Copy link
Contributor

@siv2r Please correct me if I'm wrong.

Solution would be -> setting paramBytes = param1024 instead of paramBytes = param1024*1024 in editPairForm.js and reg-form.js files?

@siv2r
Copy link
Owner Author

siv2r commented Feb 11, 2021

Solution would be -> setting paramBytes = param_1024 instead of paramBytes = param_1024*1024 in editPairForm.js and reg-form.js files?

This is not a correct approach. This will limit the file size to 2 KB instead of 1 MB. Since param is in bytes so, parm*1024 (kilobytes) and param*1024*1024 (MegaBytes)

@siv2r
Copy link
Owner Author

siv2r commented Feb 11, 2021

An ideal way would be to replace 2 with 1 in the following lines on both editPairForm.js and reg-form.js :)

https://github.com/siv2r/kidney-exchange/blob/master/scripts/editPairForm.js#L464-L488

@siv2r siv2r changed the title Max allowed packet bytest error Max allowed packet bytes error Feb 11, 2021
@96RadhikaJadhav
Copy link
Contributor

Okay will work on it. Thank you.

@siv2r
Copy link
Owner Author

siv2r commented Feb 13, 2021

Reopening issue since the error message say 2 MB instead of 1 MB

@siv2r
Copy link
Owner Author

siv2r commented Mar 10, 2021

@Abhi-1313 Feel free to work on this issue! Also do not share any personal information here. Please read the contributor's guidelines before contributing to this project.

@siv2r siv2r added the hacktoberfest For Hacktoberfest 2021 label Oct 2, 2021
@yash120102
Copy link

@siv2r can you assign this issue to me?

@inirah02
Copy link

inirah02 commented Mar 4, 2022

I want to work on this issue
I'm GSSoC'22 Contributor

@yash120102
Copy link

yash120102 commented Mar 4, 2022

@siv2r When i am trying to run the application, i can see home page but when i am navigating to login or signup i am getting
The requested resource /kidney-exchange/pages/signup.php was not found on this server. I am running it using docker

@siv2r
Copy link
Owner Author

siv2r commented Mar 4, 2022

Hmm, the docker is not updated yet. Can you try without the docker?

@Shreyxpatil
Copy link

I am begginer . can I contribute in it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cakewalk Easy to implement good first issue Good for newcomers hacktoberfest For Hacktoberfest 2021 urgent
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants