Use HTTPS for speedtest.net URLs

[mathiasbynens]

HTTP is insecure – any attacker with a privileged network position could intercept the request and possibly drop/rewrite it. HTTPS makes it much harder for anyone to do so.

Some more reasons:

• SSL’s not perfect, but we need to make surveillance as expensive as possible.
• For privacy not to be suspicious, privacy should be on by default.

[sivel]

I still need to be convinced that switching to HTTPS actually gains us something.

And you should always provide a description in a PR.

[sivel]

Again, the majority of python versions do not validate SSL certs. Python 2.7.9 and python 3.4 are the only versions that perform ssl validation by default.

Due to this, it is no more secure or private than just using HTTP.

[mathiasbynens]

Again, the majority of python versions do not validate SSL certs. Python 2.7.9 and python 3.4 are the only versions that perform ssl validation by default.

Then this patch makes speedtest-cli safer on those versions, without affecting functionality on other versions. Why would anyone be opposed to that?

(Also note that this patch makes the --share output be an HTTPS link. This is not just about requests made by the script itself.)

[sivel]

This functionality is implemented in devel