Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing Next Link Property and Insert Before? #49

Closed
sixcious opened this issue Dec 22, 2022 · 3 comments
Closed

Removing Next Link Property and Insert Before? #49

sixcious opened this issue Dec 22, 2022 · 3 comments
Assignees

Comments

@sixcious
Copy link
Owner

Hi everyone,

I'm looking for feedback on the removal of these two fields. It's these two inputs outlined in red in the UI:

Infy Scroll UI Removals

Right now, this is just about removing them from the UI. They would still be in the Save object, which you will be able to edit in the Options screen. Removing these two fields would allow the Next Link Path and the Page Element Path inputs to have more room and be 100% full width.

Next Link Property
I added this because I thought there may have been a use-case for a site secretly storing the next link in a property/attribute besides href. However, since releasing Infy, I haven't encountered a website yet that actually does this. Has anyone?

Insert Before
There are currently only 50 Database URLs that have an Insert Before path entered for them, and many of them aren't working anymore. Has anyone used this field and would prefer that it remain in the UI?

Thank you for any feedback!

@sixcious sixcious self-assigned this Dec 22, 2022
@sixcious sixcious pinned this issue Dec 22, 2022
@alexolog
Copy link

I have never used either, so I would not mind removing them from the UI.
Will it be possible to keep them in the implementation so if a site actually needs either, they can be set via other means?

@sixcious
Copy link
Owner Author

Thanks Alex for the reply. Yes, that's the plan. They can still be set in the new Options Edit Save dialog if they need to.

Thank you!

@sixcious sixcious unpinned this issue Apr 22, 2023
@sixcious
Copy link
Owner Author

Hi,

I added an option in Version 8 to show/hide these "Extra Inputs" in the Options screen for now. It's been almost a month and no one seems to have complained, so I'll leave it like this for the time being.

(One thing I forgot to do is show the Insert Before Path if one exists for the Database URL you're on if you have the option unchecked to not show. I'll add that for the next version maybe.)

Thank you! 💜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants