Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Managed version of content-aware resizing #2

Open
JimBobSquarePants opened this issue Oct 30, 2016 · 8 comments
Open

Managed version of content-aware resizing #2

JimBobSquarePants opened this issue Oct 30, 2016 · 8 comments

Comments

@JimBobSquarePants
Copy link
Member

From @KvanTTT on April 26, 2015 13:33

There is managed implementation of CAIR seam carving (content-aware) algorithm: Seam-Carving-Advanced.

It it possible to port it to your library. Is it necessary?

Copied from original issue: JimBobSquarePants/ImageProcessor#158

@JimBobSquarePants
Copy link
Member Author

A managed implementation would be amazing! 😄 I've been really unhappy with the way I've had to implement seam carving at the moment.

@JimBobSquarePants
Copy link
Member Author

Would this be something you would be interested in adding to V3?

@JimBobSquarePants
Copy link
Member Author

From @KvanTTT on December 1, 2015 15:6

I'am not interested in this library in near future :( I'am doing another things.

@JimBobSquarePants
Copy link
Member Author

From @dampee on December 1, 2015 15:52

@KvanTTT how difficult would it to port?

@JimBobSquarePants
Copy link
Member Author

From @KvanTTT on December 1, 2015 16:43

@dampee, I think it is not difficult. The only thing my library is using unsafe code snippent for performance reason (this may not compatible with Mono and some devices, but it can be removed). Are they allowed in ImageProcessor?

@JimBobSquarePants
Copy link
Member Author

@KvanTTT There's tons of unsafe code in Corefx https://github.com/dotnet/corefxlab/search?utf8=%E2%9C%93&q=unsafe so I'm not opposed to using it in ImageProcessor.

I avoided it before as I was targeting some old PCL stuff (WP8) which didn't support it but I'm sure now there are places within my codebase which could benefit. Would need lots of testing to determine where though.

@dampee If you're gonna attempt a port I would test unsafe vs safe blocks to see whether there is a speedup since we're not using System.Drawing anymore. It may be the case that it could even slow things down.

@JimBobSquarePants
Copy link
Member Author

From @dampee on December 2, 2015 0:17

Don't worry (yet). I'll touch first some simple things by the end of the year. Just looking around what I can do. (But too busy right now for customers)

@shapeh
Copy link

shapeh commented Feb 13, 2024

Not sure if seam carving would work for my issue (i.e. content-aware resizing) - it seems SC can change (redesign) e.g. a car so it no longer looks like the original, if the there's too much repetition in the image.

Added some discussion here:
input #2627

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants