Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

搜索页签改为上下布局 #3538

Closed
ttytm opened this issue Nov 30, 2021 · 8 comments
Closed

搜索页签改为上下布局 #3538

ttytm opened this issue Nov 30, 2021 · 8 comments
Assignees
Milestone

Comments

@ttytm
Copy link
Member

ttytm commented Nov 30, 2021

Feature suggestion Quicksearch Docklet

There are at least two use cases that come to my mind for this.

  • Having a search function and its results available while keeping the main Document in attention.
  • The docklet could also display the search results when clicking on a Tag.
    It would also solve problems with displaying the tag-search results in a split pane.
    (Without wanting to generalize too much) Handling it in a split pane comes with workflow distractions. General Overview is compromised and it's probably an overkill. In many cases, there will be lots of empty space on the left search results side and the preview side will be too narrow on most screens to make good use of it.
    Displaying the results in the docklet with a small contextual preview one above the other instead of a horizontal split would solve this problem.

I also think this feature would just add to the project without taking something. The advanced search feature is still good and usable as a launcher and for searching with full attention.
Reading the "Origin" article I could imagine that it could fit in the spirit and principles of the project.

I'm adding a screenshot from a fellow PKM Application as inspiration for how it can be handled.

PKM-2

@88250
Copy link
Member

88250 commented Dec 1, 2021

Hello, the search tab is not only used for tag search but it can also be used for common text keyword search (Ctrl+Shift+F after selecting text), so we design it to be separated by left and right, such as this case:

image

@ttytm
Copy link
Member Author

ttytm commented Dec 1, 2021

Hello, thanks for your reply! Yes, I can see a use case here and know about that functionality. Still I think the occasions for this use case are probably more rare comparing it to the feature request. The long list of search results tells barely a thing about the single items it is pointing at and it's hard to find something from that list. When we put a more specific search the list is getting a lot shorter with a lot of unused space on the left side of the split pane. Another thing is that for using the search function like this, the right side of the dock has to be closed else the preview gets too narrow to be usable. At least on most used screens and resolutions that are being used today.

That I get used to it and learn to love it is of course also a possibility.

@ttytm
Copy link
Member Author

ttytm commented Dec 1, 2021

Also, I really want to put some honoring words next to my critiques.
I found SiYuan on the way fighting through the currently available PKM and Note Taking Software-Junge and I'm really glad I found it.
It's just a beautiful piece of work! I'm a Designer myself and this Software is like a piece of art with a productive use to it. It is somehow like I'm able to feel that it is made with love and passion.
The WYSIWYG Editor is outstanding and on top it is content-block based. Also the handling of embedded content like videos and pdfs. Even though small of the Features have small errors here and there they are already first class! So kudos. Thank you very much is what I want to say!

@88250
Copy link
Member

88250 commented Dec 1, 2021

Thanks for the discussion. In fact, regarding the search interface, there is also discussion on the SiYuan Chinese forum https://ld246.com/article/1637045994739, some users think that the left-right layout is reasonable.

At the moment, what you said also makes sense because the tab panel can already be displayed in a tree form, and it may be more reasonable to press the top-bottom layout of the search tab. We will adjust the layout of the search tab in the near future, thank you.

@88250 88250 changed the title Quicksearch Docklet: For workflow improvement and displaying tag-search result 搜索页签改为上下布局 Dec 1, 2021
@88250 88250 added this to the backlog milestone Dec 1, 2021
@88250 88250 modified the milestones: backlog, 1.5.5 Dec 1, 2021
@ttytm
Copy link
Member Author

ttytm commented Dec 3, 2021

Thanks for the rapid work! Insane speed.

Seeing the Ambition for the left/right approach in the Chinese forums and feeling like my initial issue wasn't communicated that well I want to leave a quick annotation to this request.

I actually didn't wanted to push changing the search to a top/bottom approach. It was more about splitting the results list and the preview. Then like on the screenshot the results-list can be displayed in a widget in the toolbar / dock (That's why i called it docklet.) The preview then gets a full tab / pane in the main workspace. In a way you could see it as keeping it in left/right.

I'll try to make a full mock up to visualize how it was ment.

@ttytm
Copy link
Member Author

ttytm commented Dec 3, 2021

Sorry for the errors with spelling and semantic. I needed to edit the recent comment after posting it.

In case you're checking the comments just via mail: to read it in a way that makes more sense I recommend checking it directly on GitHub to see the most up-to-date version. Haha sorry for this again.

@ttytm
Copy link
Member Author

ttytm commented Dec 3, 2021

Visualization preview of the request.
SiYuan - 0 Please Start Here_001 (1)

@88250 88250 mentioned this issue Dec 3, 2021
@88250
Copy link
Member

88250 commented Dec 3, 2021

Oh, I understand, we need a search panel, not just a tab.

We may need to spend time to consider and implement this. In the recent releases, we will keep the design of the search tab, for the time being. The new change we can continue discussing in #3564, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants