Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need plotDiet() function for mizerMR #3

Closed
kjmurph opened this issue Sep 2, 2021 · 6 comments
Closed

Need plotDiet() function for mizerMR #3

kjmurph opened this issue Sep 2, 2021 · 6 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@kjmurph
Copy link

kjmurph commented Sep 2, 2021

Using mzerHowTo::plotDiet2() to visualise the diet proportions from a sim object created using a setMultipleResources() param object, the original 'Resource' is the only resource being plotted, rather than the new Resource 1 and Resource 2 etc...

I am playing around with the functions to see if I can get them working, but this seems like a general bug that needs addressing for the master branch of mizerMR.

@gustavdelius gustavdelius changed the title plotDiet2() with mizerMR displaying old Resource only Need plotDiet() function for mizerMR Sep 2, 2021
@gustavdelius gustavdelius added enhancement New feature or request help wanted Extra attention is needed labels Sep 2, 2021
@gustavdelius
Copy link
Member

Hi Kieran, you are quite right that mizerMR needs its own plotDiet() function, overwriting the core mizer plotDiet() function. It should be implemented similarly to how plotSpectra() is implemented. I believe that @baldrech is also working on this.

@kjmurph
Copy link
Author

kjmurph commented Sep 2, 2021

Hi Gustav. That's great, thank you! And thank you for all the great blog posts explaining the recent advances, very exciting progress!

@gustavdelius
Copy link
Member

And in addition to plotDiet() we of course need to also mask getDiet().

@gustavdelius
Copy link
Member

@baldrech and I had a discussion about this and noticed that the easiest solution would be for setMultipleResources() to set the intitial_n_pp slot to zero so that it would not give any contributions to getDiet(). Then getDiet() should already work fine with mizerMR and only plotDiet() needs to be overwritten by mizerMR to also plot the MR resources.

@baldrech
Copy link
Collaborator

I think we can close this issue now thanks to pull request #7 ?

@gustavdelius
Copy link
Member

Yes, I am closing this now but I have opened a new issue #9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants