Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid generating bad properties #47

Closed
virtuald opened this issue Sep 6, 2020 · 2 comments
Closed

Avoid generating bad properties #47

virtuald opened this issue Sep 6, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@virtuald
Copy link
Contributor

virtuald commented Sep 6, 2020

Same problem as #33, but for properties instead!

    @property
    def m(self) -> std::mutex:
        """
        :type: std::mutex
        """

Looking at it... it seems like one should do the ast.parse trick in the PropertySignature constructor. However, I'm not sure if you want to keep using those globals in FunctionSignature? Maybe it would make more sense to have some kind of validator class for storing all of those globals?

@sizmailov
Copy link
Owner

I agree, this is should be processed same way as other signatures. I consider this as a minor enchantment request (likewise #33) rather than a serious bug since it affects only modules with flawed bindings.

The library design is far from being perfect (initially was written in ~1 day as ad-hoc tool for my own use), I'm even considering complete rewrite as an option.
Therefore suggested refactoring is a plausible way.

@sizmailov
Copy link
Owner

I think the issue was (finally) resolved with #112

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants