Improve stability #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
sj-i
commented
Aug 12, 2021
sj-i
commented
- resolves failed to attach process #47, fix wrongly cached tsrm_ls_cache #48, add native file reader #49, and add debug logs #50
…alsReader I suspect that casting CData doesn't maintain its refcount and therefore releasing original CData causes access to the corrupted memory. So ZendTypeCData keeps the reference to the original CData.
the stopped process has to be resumed even if the trace returns early
Detached worker can be released via updateTargets, so there is a chance of double releasing.
…own in reading trace.
it can bypass PHP's restriction about file processing, and also avoid process invocation in the current CatFileReader
This was referenced Aug 12, 2021
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.