-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add newtype support #14
Conversation
@chessai You seemed interested in this too. |
b2063f6
to
76a1db7
Compare
I realized I can loosen some of the |
By the way: the module name is totally up for grabs. |
Once #13 is merged, I can replace the implementations in this module with calls to the more-polymorphic versions. |
How about we actually replace the existing combinators in I'm mostly concerned about offering two very similar APIs in the same package – I think that would be confusing. Thoughts @chessai? |
The competing APIs thing seems like it might be a problem to me. The new API requires a generic instance, which I'm not sure is that much of a problem. It also doesn't work with UnliftedNewtypes. I'm tempted to say keep both for now. But I'm not sure yet. |
Also make some of the implementations more readable, and export `pack` and `unpack`.
As I'm not aware of any actual users of the combinators in If anyone wants to get the old ones back, I'm sure we can figure something out. Unless you protest @chessai, I'd merge this as-is and move things into |
Ok. Agreed. My unlifted newtypes criticism wasnt very sensical. |
Thanks! |
No description provided.