Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bithumb - Do not call place order for less than minimum order size #423

Closed
sjanel opened this issue May 12, 2023 · 0 comments · Fixed by #429
Closed

Bithumb - Do not call place order for less than minimum order size #423

sjanel opened this issue May 12, 2023 · 0 comments · Fixed by #429
Labels
bug Something isn't working

Comments

@sjanel
Copy link
Owner

sjanel commented May 12, 2023

If Bithumb round down the amount, coincenter makes another call with a lower amount. This amount can reach 0:

[2023-05-12 08:56:20.705] [info] POST https://api.bithumb.com/trade/place?endpoint=%2Ftrade%2Fplace&order_currency=XRP&payment_currency=KRW&type=ask&price=577.2&units=0.000091
[2023-05-12 08:56:21.146] [warning] Bithumb told us that number of decimals is 4
[2023-05-12 08:56:21.146] [info] POST https://api.bithumb.com/trade/place?endpoint=%2Ftrade%2Fplace&order_currency=XRP&payment_currency=KRW&type=ask&price=577.2&units=0
terminate called after throwing an instance of 'cct::exception'
  what():  Bithumb error 5500
[2023-05-12 08:56:21.452] [Aborted

We should not call place order at this step.

@sjanel sjanel added the bug Something isn't working label May 12, 2023
@sjanel sjanel linked a pull request May 14, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant