Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes on roAssociativeArray and roArray #323

Merged
merged 3 commits into from
Sep 26, 2019
Merged

Fixes on roAssociativeArray and roArray #323

merged 3 commits into from
Sep 26, 2019

Conversation

lvcabral
Copy link
Contributor

@lvcabral lvcabral commented Sep 24, 2019 •
edited by sjbarag

Implements isEmpty() for RoArray and RoAssociativeArray (from ifEnum interface), and ensures doesExist() returns true for explicitly invalid properties.

fixes #320

@sjbarag sjbarag added bug Any difference between this BrightScript implementation and RBI, or otherwise unexpected behavior enhancement Any addition to this project's existing capabilities stdlib Affects the standard library included with this BrightScript implementation labels Sep 26, 2019
sjbarag
sjbarag approved these changes Sep 26, 2019
View reviewed changes
Copy link
Owner

@sjbarag sjbarag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and simple! Thanks for keeping those end-to-end tests up to date as well 😍

@sjbarag sjbarag merged commit dae8aec into sjbarag:master Sep 26, 2019
@lvcabral lvcabral mentioned this pull request Sep 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjbarag sjbarag sjbarag approved these changes

Assignees
No one assigned
Labels
bug Any difference between this BrightScript implementation and RBI, or otherwise unexpected behavior enhancement Any addition to this project's existing capabilities stdlib Affects the standard library included with this BrightScript implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

roAssociativeArray method DoesExist() returning false when the value of the item is invalid
2 participants
@lvcabral @sjbarag