Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(stdlib): Implement getString() and toStr() on RoString #362

Merged
merged 1 commit into from
Jan 21, 2020
Merged

feat(stdlib): Implement getString() and toStr() on RoString #362

merged 1 commit into from
Jan 21, 2020

Conversation

sjbarag
Copy link
Owner

@sjbarag sjbarag commented Jan 21, 2020

I forgot about these, whoops!

fixes #361

@sjbarag sjbarag added enhancement Any addition to this project's existing capabilities e2e Affects this project's end-to-end test cases (the BrightScript sample files executed during testing) stdlib Affects the standard library included with this BrightScript implementation labels Jan 21, 2020
strattonbrazil
strattonbrazil approved these changes Jan 21, 2020
View reviewed changes
Copy link
Collaborator

@strattonbrazil strattonbrazil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

@sjbarag sjbarag merged commit 1655810 into master Jan 21, 2020
@sjbarag sjbarag deleted the implement-tostr-and-getstring-for-rostring branch January 21, 2020 23:42
lvcabral referenced this pull request in lvcabral/brs-engine Mar 11, 2020
@lvcabral
feat(stdlib): Implement getString() and toStr() on RoString (#362)
9830324 
I forgot about these, whoops!

fixes #361
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strattonbrazil strattonbrazil strattonbrazil approved these changes

Assignees
No one assigned
Labels
e2e Affects this project's end-to-end test cases (the BrightScript sample files executed during testing) enhancement Any addition to this project's existing capabilities stdlib Affects the standard library included with this BrightScript implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement ifToStr in roString component
2 participants
@sjbarag @strattonbrazil