fix(parse): Restore nested block parsing #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjbarag
added
bug
sjbarag
requested review from
strattonbrazil,
alimnios72,
lkipke and
kirkyoder
sjbarag
force-pushed
the
fix-nested-loops-and-ifs
branch
3 times, most recently
from
aa1d858
to
176d71f
Compare
lkipke
approved these changes
Aug 24, 2020
| throw addError(peek(), "Expected 'end if' to terminate 'else' block"); | ||
| } | ||
| elseBranch = maybeElseBranch.body; | ||
| endIfToken = maybeElseBranch.closingToken; |
There was a problem hiding this comment.
Ooh nice does this mean the endIfToken is populated now? I ran into this when I was writing the coverage tool
There was a problem hiding this comment.
It does! That's where a few of the snapshot updates came into play 😃
alimnios72
approved these changes
Aug 24, 2020
I'd accidentally broken nested-block parsing in #510! This fixes that and ensures that `block()` always consumes the block-closing token.
sjbarag
force-pushed
the
fix-nested-loops-and-ifs
branch
from
176d71f
to
b041596
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd accidentally broken nested-block parsing in #510! This fixes that and ensures that
block()always consumes the block-closing token.