Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lexer): Add support for explicit integer literals #637

Merged
merged 1 commit into from
Apr 7, 2021
Merged

fix(lexer): Add support for explicit integer literals #637

merged 1 commit into from
Apr 7, 2021

Conversation

Vasya-M
Copy link
Contributor

@Vasya-M Vasya-M commented Apr 7, 2021

 this PR resolves #627 issue
what were done:

  • added support for % suffix in integer literals
  • added unit test for imlementation(lexer)
  • added e2e test.

sjbarag
sjbarag approved these changes Apr 7, 2021
View reviewed changes
Copy link
Owner

@sjbarag sjbarag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could have sworn we fixed this already, but perhaps I'm mistaken. Thanks for clean patch, @Vasya-M !

@sjbarag sjbarag changed the title add support for explicit integer literals fix(lexer): add support for explicit integer literals Apr 7, 2021
@sjbarag sjbarag added bug Any difference between this BrightScript implementation and RBI, or otherwise unexpected behavior lexer Affects this project's lexer (aka scanner) labels Apr 7, 2021
@sjbarag sjbarag changed the title fix(lexer): add support for explicit integer literals fix(lexer): Add support for explicit integer literals Apr 7, 2021
@sjbarag sjbarag merged commit 6dd52c1 into sjbarag:main Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjbarag sjbarag sjbarag approved these changes

@lkipke lkipke Awaiting requested review from lkipke

@alimnios72 alimnios72 Awaiting requested review from alimnios72

Assignees
No one assigned
Labels
bug Any difference between this BrightScript implementation and RBI, or otherwise unexpected behavior lexer Affects this project's lexer (aka scanner)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support "%" type declaration character
2 participants
@Vasya-M @sjbarag