Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Per-endpoint ring metrics #119

Closed
cddr opened this issue May 31, 2017 · 1 comment
Closed

Per-endpoint ring metrics #119

cddr opened this issue May 31, 2017 · 1 comment

Comments

@cddr
Copy link

cddr commented May 31, 2017

Seems like it would be useful to be able to record metrics for each endpoint in an app. In theory since it just wraps a handler, you could wrap each endpoint individually, but then you'd register the same metric twice. Would be nice if the "instrument-ring" function accepted a prefix that could be used to ensure each metric is uniquely named when wrapping multiple endpoints.

Does that make sense? I can come up with a PR if this sounds ok.

@michaelklishin
Copy link
Collaborator

@cddr sounds worth exploring. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants