Added custom reservoir support #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| (defn uniform-reservior | ||
| "Create a uniform reservior, which uses Vitter's Algorithm R to | ||
| produce a statistically representative sample. Default size: 1028." | ||
| ([] (UniformReservoir.)) |
There was a problem hiding this comment.
Sorry to nitpick but can we keep the argument vector and function body on separate lines, here and everywhere else?
Signed-off-by: Ning Sun <sunng@about.me>
|
@michaelklishin Thanks for fast response. I just updated the style. |
|
Thank you! |
|
@michaelklishin possible to make a release for this? |
|
@sunng87 I'll try making one over the weekend. |
|
@sunng87 |
|
@michaelklishin Excellent! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reservoir as an important feature is missing in current metrics-clojure. It allows histogram based metrics (histogram and timer) to drop some data based on custom strategy (uniform, sliding window, etc). This is helpful when we want to collect timer for last minute, for example.
The bad part is upstream API doesn't provide entry point for custom reservoir in
MetricRegistry, so there is no way to use this feature withMetricRegistry's get-or-add API. Duplicated creation will lead toIllegalArgumentException. So I created new function for timer and histogram.@michaelklishin @sjl PTAL