Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Endpoint uses https scheme when use_ssl is false #38

Closed
Sevenannn opened this issue May 20, 2024 · 2 comments · Fixed by #39
Closed

Bug: Endpoint uses https scheme when use_ssl is false #38

Sevenannn opened this issue May 20, 2024 · 2 comments · Fixed by #39

Comments

@Sevenannn
Copy link

I already have a fix in mind for this issue, and I can make a PR if this issue is reviewed and approved, thanks!

Description

The current spark-connect-rs library configures all endpoints to https scheme. When tls feature is enabled, connection cannot be successfully made to server without TLS configured, for example, when connecting to a Spark cluster set up at localhost

Expected Behavior

When tls feature is enabled in spark-connect-rs crate, connection to server with / without TLS configured should both be successful

Proposed Fix

Default endpoint scheme to http, set it to https only when use_ssl=true is specified in connection string

Related Issue

@sjrusso8
Copy link
Owner

sjrusso8 commented May 21, 2024

@Sevenannn Good call. I probably overlooked this because this error never popped up when running spark connect locally.

I created PR #39 to correct this.

@Sevenannn
Copy link
Author

@sjrusso8 Thanks for taking a look at this! The PR looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants