Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atom Editor 1.6 i686 isn't starting properly #4

Closed
rafaelsoaresbr opened this issue Mar 28, 2016 · 9 comments
Closed

Atom Editor 1.6 i686 isn't starting properly #4

rafaelsoaresbr opened this issue Mar 28, 2016 · 9 comments

Comments

@rafaelsoaresbr
Copy link

screenshot at 2016-03-27 23 52 28

After updating from 1.5 to 1.6, Atom isn't starting properly. Any hints?

@rafaelsoaresbr rafaelsoaresbr changed the title Atom Editor 1.7 i686 isn't starting properly Atom Editor 1.6 i686 isn't starting properly Mar 28, 2016
@rafaelsoaresbr
Copy link
Author

This Issue is reported upstream
atom/atom#10819

@sjug
Copy link
Owner

sjug commented Mar 30, 2016

Hey @rafaelsoaresbr, thanks for the heads up. We can keep this issue open and I'll keep updating the AUR package as upstream rolls out the fixes.

Also if there's a patch released before it's merged we can also put that into the package.

@rafaelsoaresbr
Copy link
Author

@sjug Version 1.6.2 will build and run successfully on Arch Linux i686 after this pull request (merged):
nodegit/nodegit#980

I've edited packages.json (inside source tar ball) on line #40:

"nodegit": "0.12.0",  -> "nodegit": "0.12.2", 

Can you make a patch for it? Or just include a condition in you PKGBUILD's prepare() fase until next release of Atom:

if [[ "$CARCH" == "i686" ]]; then
    --some useful code here--
fi

This should do the trick for others distros as well:
atom/atom#10819
nodegit/nodegit#974

Future versions may build and run as well after this pull request (yet to be merged):
atom/atom#11401

Thanks @johnhaley81 @tbranyen and @SEAPUNK

@sjug
Copy link
Owner

sjug commented Apr 13, 2016

Hey Rafa,

This is still an issue on 1.7.0?

@sjug
Copy link
Owner

sjug commented Apr 13, 2016

Fixed, please let me know if it works! 276db3d

@sjug sjug closed this as completed Apr 13, 2016
@rafaelsoaresbr
Copy link
Author

Thanks, I'm building it right now.

@SEAPUNK
Copy link

SEAPUNK commented Apr 13, 2016

Same. Will let you know if it's fixed on my end.

@SEAPUNK
Copy link

SEAPUNK commented Apr 13, 2016

It works, thanks.

@roshimon
Copy link

Upgrading to atom 1.8.0-beta1 has fixed the issue for me. Working flawlessly now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants