Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StatusBar Calculation Wrong #14

Closed
grote opened this issue Oct 2, 2016 · 9 comments
Closed

StatusBar Calculation Wrong #14

grote opened this issue Oct 2, 2016 · 9 comments
Assignees
Milestone

Comments

@grote
Copy link

grote commented Oct 2, 2016

First of all thanks for this awesome library, I love it! πŸ˜„ πŸ™‡β€β™‚οΈ

The latest version introduced a bug (probably by 91e9539).

device-2016-10-02-173553

This is how it looks with 1.4.0

device-2016-10-02-173716

@joseluisametller
Copy link

I can reproduce it as well, at least on KitKat. I'm using 1.4.0 for the moment...

@sjwall
Copy link
Owner

sjwall commented Oct 3, 2016

Hi, thanks letting me know about the issue.

It looks like the issue is occurring due to changes made in d70026e, it is incorrectly applying the status bar height when it has already clipped the bounds to the activity.

I hope to have a fix out later today or tomorrow

@sjwall sjwall self-assigned this Oct 3, 2016
@sjwall sjwall added this to the v1.4.2 milestone Oct 3, 2016
@sjwall
Copy link
Owner

sjwall commented Oct 3, 2016

Changes released in v1.4.2, could you please confirm that these changes fix this issue?

@joseluisametller
Copy link

Using 1.4.2 on my gradle file I can still reproduce it on KitKat.

@sjwall
Copy link
Owner

sjwall commented Oct 4, 2016

The issue is effecting KitKat and lower

@sjwall
Copy link
Owner

sjwall commented Oct 4, 2016

Issue is the call to mClipToView.getLocationOnScreen(location); in updateClipBounds().
It is correctly returning the views screen position from top on KitKat and lower. On Lollipop and newer this returns 0 all the time.

Working on fix for this

@sjwall
Copy link
Owner

sjwall commented Oct 5, 2016

Should be fixed now and released in v1.4.3. Found different way of retrieving the activity screen location. @joseluisametller and @grote could you both please confirm that this fixes the issue for you? I have tested it with Transportr on Kitkat and Nougat, so I have high hopes

@sjwall sjwall modified the milestones: v1.4.3, v1.4.2 Oct 5, 2016
@joseluisametller
Copy link

@sjwall I can confirm it is working perfectly fine on KitKat. Thanks a lot for your work :D

@sjwall
Copy link
Owner

sjwall commented Oct 7, 2016

@joseluisametller Thanks for confirming. Closing as issue has been fixed

@sjwall sjwall closed this as completed Oct 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants