Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target focus shows below actionmode in 1.6 version #22

Closed
chinmoyeedash opened this issue Nov 12, 2016 · 7 comments
Closed

Target focus shows below actionmode in 1.6 version #22

chinmoyeedash opened this issue Nov 12, 2016 · 7 comments
Milestone

Comments

@chinmoyeedash
Copy link

I was using 1.1.4 version which shows the target correctly over the actionmode, but now if i update the dependency to 1.6, the target shows below the actionmode.

@sjwall
Copy link
Owner

sjwall commented Nov 13, 2016

I shall investigate and see what I can do to fix it

sjwall added a commit that referenced this issue Nov 18, 2016
@sjwall sjwall added this to the v1.6.1 milestone Nov 18, 2016
sjwall added a commit that referenced this issue Nov 18, 2016
@sjwall
Copy link
Owner

sjwall commented Nov 18, 2016

This should be fixed in release v1.6.1. Please let me know how you get on with it :)

@chinmoyeedash
Copy link
Author

Nope.. 1.6.1 also didn't help

@sjwall
Copy link
Owner

sjwall commented Nov 21, 2016

Could you please provide more detail on the following so that I can try and replicate it better:

  • How you are targeting the actionmode setTarget(View)?
  • What actionmode you are using: Android, support library or custom?
  • How are you creating the actionmode?
  • What version of Android?

Thanks

@chinmoyeedash
Copy link
Author

  • Setting target by --- setTarget(findViewById(R.id.menu_next))

  • using action mode - support library-v7

  • creating actionmode on listview selections
    if (hasCheckedElement && mode == null)
    // there are some selected items, start the actionMode
    mode = startSupportActionMode(new ModeCallback());

  • Tested it on my Android 5.0 and 4.2.2

sjwall added a commit that referenced this issue Nov 29, 2016
@sjwall
Copy link
Owner

sjwall commented Nov 29, 2016

I have changed the example to use findViewById but I am still unable to replicate.
You could try wrapping the prompt creation in a post like below. The support ActionMode uses this as well. If the post fixes the issue for you I will add it into the library (I need to do some more research but I think it should be doing this anyway).

getWindow().getDecorView().post(new Runnable() {
    @Override
    public void run() {
        // Create prompt here
    }
});

You could also try running the sample app (cloning or from the play store) and seeing if that has the issue and if it has any differences to your implementation.

Let me know if this helps

@sjwall
Copy link
Owner

sjwall commented Jan 7, 2017

No response for a month so assuming that your question has been answered. Please reopen if not

@sjwall sjwall closed this as completed Jan 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants