Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage is not flexible enough for fragments / dialogfragments #24

Closed
hwesley opened this issue Nov 16, 2016 · 5 comments
Closed

Usage is not flexible enough for fragments / dialogfragments #24

hwesley opened this issue Nov 16, 2016 · 5 comments

Comments

@hwesley
Copy link

hwesley commented Nov 16, 2016

I'm using your library in my app. I noticed it's strongly connected to an activity for usage.

I have a DialogFragment in my app (bottom sheet) which is displayed in a different window / decorview than the one from my activity. When I trigger the prompt it is thus shown behind the dialog.

By changing the constructor & builder so it accepts a context (instead of activity) and a decorview, usage is a lot more flexible.

Any chance this could be changed in your library?

@sjwall
Copy link
Owner

sjwall commented Nov 16, 2016

I shall look into what options there are for decoupling it from activity

@sjwall sjwall added this to the v1.7.0 milestone Nov 18, 2016
@sjwall sjwall modified the milestones: v1.10, v1.7.0 Feb 12, 2017
@sjwall sjwall self-assigned this Feb 12, 2017
@sjwall sjwall modified the milestones: v2.0.0, v1.10 Feb 26, 2017
@usernotnull
Copy link

+1

@venu1412
Copy link

+1
I am also facing the same issue , Can i know any tentative schedule when this bug will get fixed.

@sjwall
Copy link
Owner

sjwall commented May 21, 2017

I am currently working on this, hopefully it won't take more than a couple of weeks

@sjwall
Copy link
Owner

sjwall commented Jul 2, 2017

This change has been released in v1.11.0.

The ResourceFinder interface is used to find the required resources with an implementation for dialogs and activities supplied with the library.

@sjwall sjwall closed this as completed Jul 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants