Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop undefined in boilerplate AMD setup? #30

Closed
sjwilliams opened this issue Jul 18, 2017 · 1 comment
Closed

Drop undefined in boilerplate AMD setup? #30

sjwilliams opened this issue Jul 18, 2017 · 1 comment
Assignees

Comments

@sjwilliams
Copy link
Owner

This pattern is causing issue for new NYT site and unclear what purpose it serves.

(function(factory) {
  if (typeof define === 'function' && define.amd) {
    define(['jquery', undefined], factory);
  } else {
    factory(jQuery, undefined);
  }
}(function($, undefined) {
@sjwilliams sjwilliams self-assigned this Jul 18, 2017
@sjwilliams
Copy link
Owner Author

Addressed in 0.3.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant