Skip to content
This repository has been archived by the owner on Jan 2, 2022. It is now read-only.

Hytilities message detection doesn't support other languages. #1

Closed
ghost opened this issue Jul 28, 2020 · 0 comments · Fixed by #25
Closed

Hytilities message detection doesn't support other languages. #1

ghost opened this issue Jul 28, 2020 · 0 comments · Fixed by #25
Labels
bug Something isn't working enhancement New feature or request

Comments

@ghost
Copy link

ghost commented Jul 28, 2020

Users should be able to select the detection language (English, by default) through the GUI using a SELECTOR property type.

A way to improve this would be fetch the users currently selected language, then automatically change the language it will use for regex detection & select the file based on that.

https://api.sk1er.club/player/username will return

{
  "userLanguage": "ENGLISH"
}

and with that, it would select the regex file with the corresponding language lettering chosen through a switch

switch (language) {
    case "ENGLISH":
        return "en"; // suffix to the end of the `regex_name.json`
    case "SPANISH":
        return "es"
    // etc...
}

(regex_en in this case)

These would need to be community-sourced, as I personally do not have the time to run through all 16 (as of today) languages and support them through regex.

@ghost ghost added bug Something isn't working enhancement New feature or request labels Jul 28, 2020
@ghost ghost closed this as completed in #25 Oct 3, 2020
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

0 participants