Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calibration Utility Updates #287

Merged
merged 9 commits into from Jul 5, 2023
Merged

Calibration Utility Updates #287

merged 9 commits into from Jul 5, 2023

Conversation

landmanbester
Copy link
Collaborator

  • Tests added / passed

    $ py.test -v -s africanus

    If the pep8 tests fail, the quickest way to correct
    this is to run autopep8 and then flake8 and
    pycodestyle to fix the remaining issues.

    $ pip install -U autopep8 flake8 pycodestyle
    $ autopep8 -r -i africanus
    $ flake8 africanus
    $ pycodestyle africanus
    
  • Fully documented, including HISTORY.rst for all changes
    and one of the docs/*-api.rst files for new API

    To build the docs locally:

    pip install -r requirements.readthedocs.txt
    cd docs
    READTHEDOCS=True make html
    

Add a check to make sure the correlation axis is never larger than 2

africanus/calibration/utils/corrupt_vis.py Outdated Show resolved Hide resolved
africanus/gps/kernels.py Outdated Show resolved Hide resolved
utimes, time_bin_counts = np.unique(time, return_counts=True)
n_time = len(utimes)
if utimes_per_chunk == 0 or utimes_per_chunk == -1:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about:

Suggested change
if utimes_per_chunk == 0 or utimes_per_chunk == -1:
if utimes_per_chunk <= 0:

africanus/calibration/utils/utils.py Outdated Show resolved Hide resolved
africanus/calibration/utils/utils.py Outdated Show resolved Hide resolved
landmanbester and others added 2 commits July 5, 2023 12:22
@sjperkins
Copy link
Member

I forgot to ask for the update to HISTORY.rst. If you prefix the commit with [skip ci] it'll avoid another ci run.

@sjperkins sjperkins changed the title Calutils Calibration Utility Updates Jul 5, 2023
@landmanbester
Copy link
Collaborator Author

Oops, forgot about that. Thanks @sjperkins

@sjperkins sjperkins merged commit 2e66bde into ratt-ru:master Jul 5, 2023
@landmanbester landmanbester deleted the calutils branch July 5, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants