Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address warnings #292

Merged
merged 15 commits into from Jan 30, 2024
Merged

Address warnings #292

merged 15 commits into from Jan 30, 2024

Conversation

sjperkins
Copy link
Member

  • Tests added / passed

    $ py.test -v -s africanus

    If the pre-commit tests fail, install and
    run the pre-commit hooks in your development
    virtuale environment:

    $ pip install pre-commit
    $ pre-commit install
    $ pre-commit run -a
  • Fully documented, including HISTORY.rst for all changes
    and one of the docs/*-api.rst files for new API

    To build the docs locally:

    pip install -r requirements.readthedocs.txt
    cd docs
    READTHEDOCS=True make html

@sjperkins sjperkins merged commit 034b3ce into master Jan 30, 2024
@sjperkins sjperkins deleted the address-warnings branch January 30, 2024 14:54
@@ -5,7 +5,7 @@ def stokes2corr(vis_in, vis_out, policy_type):
pass


@overload(stokes2corr, inline="always")
@overload(stokes2corr, inline="always", prefer_literal=True)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bennahugo Just letting you know that the test cases you wrote easily highlighted up the above needed change, due to the following https://numba.readthedocs.io/en/stable/reference/deprecation.html#deprecation-of-old-style-numba-captured-errors.

So the test cases were useful to have and I didn't have to understand the implementation to do the upgrade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant