Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #199. #200

Merged
merged 3 commits into from Apr 12, 2022
Merged

Fix #199. #200

merged 3 commits into from Apr 12, 2022

Conversation

JSKenyon
Copy link
Collaborator

@JSKenyon JSKenyon commented Apr 12, 2022

  • Tests added / passed

    $ py.test -v -s daskms/tests

    If the pep8 tests fail, the quickest way to correct
    this is to run autopep8 and then flake8 and
    pycodestyle to fix the remaining issues.

    $ pip install -U autopep8 flake8 pycodestyle
    $ autopep8 -r -i daskms
    $ flake8 daskms
    $ pycodestyle daskms
    
  • Fully documented, including HISTORY.rst for all changes
    and one of the docs/*-api.rst files for new API

    To build the docs locally:

    pip install -r requirements.readthedocs.txt
    cd docs
    READTHEDOCS=True make html
    

This changes the behaviour of xds_to_zarr. A new dataset will be constructed after selection of data_vars and coords but before construction of the schemas. This means that selecting columns (data_vars) will no longer produce partially initialised values for unselected data_vars/coords. This also begins addressing #171 and #118 (for zarr) - more work will still be needed to reconcile chunking and propagate the changes to the casa/parquet interfaces.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant