Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change setmaxcachesize to require a read lock, not a write lock #281

Merged
merged 2 commits into from Aug 2, 2023

Conversation

sjperkins
Copy link
Member

@sjperkins sjperkins commented Aug 1, 2023

Closes #280

Previously, setmaxcachesize was called with a write lock, but this was problematic for readonly tables as setmaxcachesize was called during read ops.

As setmaxcachesize only modifies the internal casacore column caching, this can safely be made a read operation.

  • Tests added / passed

    $ py.test -v -s daskms/tests

    If the pep8 tests fail, the quickest way to correct
    this is to run autopep8 and then flake8 and
    pycodestyle to fix the remaining issues.

    $ pip install -U autopep8 flake8 pycodestyle
    $ autopep8 -r -i daskms
    $ flake8 daskms
    $ pycodestyle daskms
    
  • Fully documented, including HISTORY.rst for all changes
    and one of the docs/*-api.rst files for new API

    To build the docs locally:

    pip install -r requirements.readthedocs.txt
    cd docs
    READTHEDOCS=True make html
    

@sjperkins
Copy link
Member Author

sjperkins commented Aug 1, 2023

@landmanbester Do you want to give this branch a try?

@landmanbester
Copy link
Collaborator

Thanks @sjperkins. I've kicked it off, so far so good

@landmanbester
Copy link
Collaborator

It ran through successfully so I think we are all good. Thanks

@sjperkins sjperkins changed the title setmaxcachesize should only require a READLOCK Change setmaxcachesize to require a read lock, not a write lock Aug 2, 2023
@sjperkins sjperkins merged commit 51c8ae5 into master Aug 2, 2023
@sjperkins sjperkins deleted the setmaxcachesize-to-only-require-READLOCK branch August 2, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

convert over NetFS
2 participants