Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard-coded numbers in synthesis.py #2

Closed
LeviBarnes opened this issue Mar 19, 2015 · 4 comments
Closed

Hard-coded numbers in synthesis.py #2

LeviBarnes opened this issue Mar 19, 2015 · 4 comments
Assignees

Comments

@LeviBarnes
Copy link

Calls to wkernelaf in synthesis.py contain hard-coded numbes 257 and 15. Those would be better understood if they had text names. Also, should those be adjustable in any way?

@bnikolic
Copy link
Contributor

I will try to have a look at this. However, in case I don't Vlad could you please put it onto the the list of things to look into?

@vlad7235
Copy link

Yes, I'll have a look.

On 19/03/15 17:25, bnikolic wrote:

I will try to have a look at this. However, in case I don't Vlad could
you please put it onto the the list of things to look into?


Reply to this email directly or view it on GitHub
#2 (comment).

@bnikolic
Copy link
Contributor

I've removed the hard coded values and replaced them with parameters. The choice of parameters is illustrated in file doc/wkernel.rstw in commit
22ec7f5

@bnikolic
Copy link
Contributor

I think that closes it for now. We should have a function which computes suitable size of the far-field given maximum w value in a dataset

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants