Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We need to recalculate the nearest sensor when we update the AQI #29

Closed
obra opened this issue Sep 8, 2020 · 3 comments · Fixed by #42
Closed

We need to recalculate the nearest sensor when we update the AQI #29

obra opened this issue Sep 8, 2020 · 3 comments · Fixed by #42

Comments

@obra
Copy link
Collaborator

obra commented Sep 8, 2020

I had the app up while driving home today. Without a browser refresh, the app continued to show the AQI at my starting location, even though it updated every minute.

@skalnik
Copy link
Owner

skalnik commented Sep 8, 2020

I dig this idea. I think it'd definitely blow the rate limit regularly unless we pair this with #22.

@obra
Copy link
Collaborator Author

obra commented Sep 8, 2020

I don't see why it would. We don't have to throw away the sensors list while it's in memory.

@skalnik
Copy link
Owner

skalnik commented Sep 8, 2020

I don't see why it would. We don't have to throw away the sensors list while it's in memory.

Ah that's true, as long as we keep the list around it should be fine!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants