-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SVG renderer falling behind.. #15
Comments
I really like the fact that the text hovers above the graph, so I am a bit sceptical to the two-column approach. |
I think your solution with fading text is great and will sure inspire ;) me to improve the next version! But I would prefer SVG because the graphic can be then exported as vector graphics into other documents.. I put the question just to know if there are other ppl (than you and me) who are interested. |
@ctzurcanu : it would be nice to have both |
@skanaar true. that is why we can use https://github.com/gabelerner/canvg (even more: I never said the project should have only SVG renderer. I think it should have both) |
@ctzurcanu , you might want to have a chat with @korroz who was interested in an SVG renderer. |
+1 |
I was interested in SVG on behalf of nomnoml because my opinion is that it is a better match technology-wise than raster. And as pointed out, if you have SVG you get raster images for free as well, you don't even need a library like canvg, it's a trivial piece of code (well at least in a browser). When talking a bit about SVG rendering with @skanaar we went into the direction that it would be best if rendering got abstracted some more and then SVG support could be built as an alternative renderer. That roughly means that a middle step between the layouter and the renderer should be added to create a simpler object model that is easy for the renderer (canvas or svg) to consume. In the end it is up to @skanaar what he wants to accept. |
@korroz I am not sure if you have tried my (alternative) svg renderer. It is already following the canvas renderer quite closely already. I did not see your email being public. I would have a longer conversation on this or we can have it at https://github.com/ctzurcanu/nomnoml |
@ctzurcanu I did check your branch out actually. I tried all forks of nomnoml out in fact, hehe. Oh and I noticed that I didn't have an email on my profile so I set one, it should be there now. |
I am pretty swamped with work/hobbies right now but will definitely look into this. |
Closing this as it is more of a discussion thread than an actual issue. |
As you know, I have created some time ago an SVG renderer for nomnoml: https://github.com/ctzurcanu/nomnoml/blob/master/lib/skanaar.svg.js
It has zoom and pan that solves the large diagram issues.
Should I take some time to make it compatible with the newest revision and then pull request?
Anyone else interested in this?
The text was updated successfully, but these errors were encountered: