Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVG renderer falling behind.. #15

Closed
ctzurcanu opened this issue May 14, 2015 · 11 comments
Closed

SVG renderer falling behind.. #15

ctzurcanu opened this issue May 14, 2015 · 11 comments

Comments

@ctzurcanu
Copy link

As you know, I have created some time ago an SVG renderer for nomnoml: https://github.com/ctzurcanu/nomnoml/blob/master/lib/skanaar.svg.js
It has zoom and pan that solves the large diagram issues.
Should I take some time to make it compatible with the newest revision and then pull request?
Anyone else interested in this?

@skanaar
Copy link
Owner

skanaar commented May 25, 2015

I really like the fact that the text hovers above the graph, so I am a bit sceptical to the two-column approach.
But I got inspired! and implemented some custom pan and zoom handlers: http://www.nomnoml.com/releasecandidate/

@ctzurcanu
Copy link
Author

I think your solution with fading text is great and will sure inspire ;) me to improve the next version! But I would prefer SVG because the graphic can be then exported as vector graphics into other documents..

I put the question just to know if there are other ppl (than you and me) who are interested.

@ctzurcanu ctzurcanu mentioned this issue May 26, 2015
@skanaar
Copy link
Owner

skanaar commented May 26, 2015

@ctzurcanu : it would be nice to have both Save PNG and Save SVG butttons. Bitmap images are so ubiquitous that I am hesitant to drop support completely.

@ctzurcanu
Copy link
Author

@skanaar true. that is why we can use https://github.com/gabelerner/canvg (even more: I never said the project should have only SVG renderer. I think it should have both)

@skanaar
Copy link
Owner

skanaar commented May 26, 2015

@ctzurcanu , you might want to have a chat with @korroz who was interested in an SVG renderer.

@amoosbr
Copy link

amoosbr commented May 26, 2015

+1

@korroz
Copy link
Contributor

korroz commented May 27, 2015

I was interested in SVG on behalf of nomnoml because my opinion is that it is a better match technology-wise than raster. And as pointed out, if you have SVG you get raster images for free as well, you don't even need a library like canvg, it's a trivial piece of code (well at least in a browser).

When talking a bit about SVG rendering with @skanaar we went into the direction that it would be best if rendering got abstracted some more and then SVG support could be built as an alternative renderer. That roughly means that a middle step between the layouter and the renderer should be added to create a simpler object model that is easy for the renderer (canvas or svg) to consume.

In the end it is up to @skanaar what he wants to accept.

@ctzurcanu
Copy link
Author

@korroz I am not sure if you have tried my (alternative) svg renderer. It is already following the canvas renderer quite closely already. I did not see your email being public. I would have a longer conversation on this or we can have it at https://github.com/ctzurcanu/nomnoml

@korroz
Copy link
Contributor

korroz commented May 27, 2015

@ctzurcanu I did check your branch out actually. I tried all forks of nomnoml out in fact, hehe. Oh and I noticed that I didn't have an email on my profile so I set one, it should be there now.

@skanaar
Copy link
Owner

skanaar commented May 29, 2015

I am pretty swamped with work/hobbies right now but will definitely look into this.
If anyone have time to help me with modifing the grammar-file so that nomnoml supports escaping of [ ] - characters and chained associations that would be very appreciated.

@skanaar
Copy link
Owner

skanaar commented Aug 4, 2015

Closing this as it is more of a discussion thread than an actual issue.

@skanaar skanaar closed this as completed Aug 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants