Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ARM/Apple M1 support #32

Closed
idontusenumbers opened this issue Dec 16, 2021 · 4 comments · Fixed by #33
Closed

Add ARM/Apple M1 support #32

idontusenumbers opened this issue Dec 16, 2021 · 4 comments · Fixed by #33
Assignees
@pingvinen
Labels
enhancement New feature or request

Comments

@idontusenumbers
Copy link

Any chance you could add ARM/Apple M1 support? Seems the upstream image has arm support already.
@pingvinen pingvinen mentioned this issue Dec 27, 2021
Merged
@pingvinen
Copy link
Contributor

Hi @idontusenumbers

I have made a PR, which upgrades the entire stack. As far as I can see, nodejs introduced Apple M1 support in version 16 and we were running on node 12 :)

Would you be willing to build the image locally using the branch and test it out? I do not have an Apple computer :)

@pingvinen pingvinen self-assigned this Dec 27, 2021
@pingvinen pingvinen added the enhancement New feature or request label Dec 27, 2021
@pingvinen
Copy link
Contributor

Released as version 0.4.0 ... https://hub.docker.com/r/skarpdev/aws-secrets-manager-emulator/tags

@idontusenumbers
Copy link
Author

idontusenumbers commented Jan 6, 2022 •
edited
Loading

I'm not sure what's involved with pushing an ARM version of the image, but it appears to be missing: https://hub.docker.com/r/skarpdev/aws-secrets-manager-emulator/tags

This might provide some guidance: https://www.docker.com/blog/multi-arch-build-and-images-the-simple-way/

@nover nover mentioned this issue Jan 7, 2022
Closed
@nover
Copy link

nover commented Jan 7, 2022

Thanks for reporting @idontusenumbers, we're tracking this via #34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pingvinen pingvinen

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
3 participants
@nover @pingvinen @idontusenumbers