Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not compatible with Umbraco 11/AspNetCore 7 #36

Closed
afabri73 opened this issue Jun 14, 2023 · 7 comments
Closed

Not compatible with Umbraco 11/AspNetCore 7 #36

afabri73 opened this issue Jun 14, 2023 · 7 comments

Comments

@afabri73
Copy link

Hi,
There are problems with Umbraco 11/AspNetCore 7
I tried to create a new Custom Package but I cannot save it.

Can you update the package to make it compatible with Umbraco 11/AspNetCore 7?

Thank you
Adriano

@skartknet
Copy link
Owner

Hi Adriano,

I have tested the latest Iconic version 5.2.1 with Umbraco 11.4.4 and it's working fine. Can you give more information like:

  • What Iconic version you are using?
  • What Umbraco version?
  • Is this a clean install or an upgrade?
  • What error are you getting?

@robertjf
Copy link

@afabri73 it's also worth looking at the Browser Dev Tools (typically F12) when reporting the error - are there any errors in the javascript console?

@afabri73
Copy link
Author

HI Robert,
I'm using the latest stable Umbraco release v11.4.0 and the latest stable version of Our.Iconic v5.2.1

There several problems:

  • on STAGE Environment after creating the DataType, I click on "Add Package" but the settings window does not appear and I am immediately redirected to the Contents section (tried on PC and MAC with Chrome, Firefox, Edge and Safari)
  • on DEV/LOCAL Environment after creating the DataType and clicked on "Add Package", the settings window appear but
    • Selecting the css "solid.css" (template "" and regex ".(fa-[\w-]+):before {" ), I don't see any icons
    • Selecting the "all.css" css (same template and same regex) I see all square icons with an X
    • Selecting the "all.css" css (template "" and the same regex) I only see the brand icons correctly
    • Selecting the css "all.css" (template "" and same regex) I see the regular icons but several icons are square with an X and others are empty

After Our.Iconic installation, Umbraco are very unstable in all environments and I receive several UmbracoAPI error.
Uninstalling Our.Iconic, the system becomes stable again

In the console I received some errors, but i didn't think about taking screenshots and now i uninstalled the package
This is a fresh Umbraco and Our.Iconic installations (no update)

Thank you for the support
Adriano

@skartknet
Copy link
Owner

If you have removed the package and are unable to reproduce I'm afraid we can't help you. If you try to install it again and we can get an idea what the errors are please reopen this ticket.

I'm closing it because we can't reproduce.

@afabri73
Copy link
Author

Hi,
I reinstalled your package (v5.2.1) and in my local machine it function properly.
I configured all as you describe, I correctly pick the Icon and I see the icon in frontend.
After I publish to my developer website I cannot manage the Iconic Package Configurations and I cannot use the picker in content.

DEVELOPER WEBSITE

When I go to Settings > Datatype > Iconic - Icon Picker I don't see the package configuration I created.
SS1 - Datatype

I see an error in Console
SS2 - Error

And in Content Section I don't see selected icon and can't use the Add button (no action after pressed).
SS3 - Content IconPicker

LOCAL WEBSITE (My PC) same DB used with Developer Website

ss1 - Datatype (local)

SS3 - Content IconPicker (local)

Can you reopen the issue and can you give me support?
Thank you
Adriano

@robertjf
Copy link

@afabri73 this may be a similar issue for you to this one on the gmaps repository:

ArnoldV/Our.Umbraco.GMaps#145

Try changing the smidge cachebuster settings and see if that resolves it for you.

@afabri73
Copy link
Author

Hi Robert,
first of all thank you for the support.
Thanks to the link you sent me I found that the problem is indeed due to the cache configuration.
What I don't understand is why the Developer Website site didn't use the Development configuration.
Indeed in base appsettings.json I had this configuration:

"RuntimeMinification": {
    "UseInMemoryCache": false,
    "CacheBuster": "Version",
    "Version": "1234"
}

while in appsettings.Development.json I had this configuration:

"RuntimeMinification": {
    "UseInMemoryCache": true,
    "CacheBuster": "Timestamp"
}

So it seems that development configuration didn't overriding the base appsettings.
So I tried to publish the project specifying the environment and this solved the problem.

dotnet publish $sourcePath\$solutionName\$projectName\$progectFile -o $destinationPath -f net7.0 -c Debug /p:EnvironmentName=Development

Thanks again for the support
Adriano

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants