Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSR demo in readme does not work #1587

Closed
Pyrolistical opened this issue Jun 29, 2022 · 1 comment
Closed

SSR demo in readme does not work #1587

Pyrolistical opened this issue Jun 29, 2022 · 1 comment

Comments

@Pyrolistical
Copy link

Pyrolistical commented Jun 29, 2022

Bug report

  • Skate version: unknown what demo used
  • Affected browsers (and versions): Chrome 103

Current behaviour

This JS bin demo

[See it in action!](http://jsbin.com/cilocowozu/2/edit?html,output)
shows and output of

Hello, !World

Expected behaviour

Expected

Hello, World!

The demo script doesn't use slot as expected.

Cause

The demo violates the spec and attempts to attachShadow to unregistered custom elements x-hello and x-yell. I manually changed x-hello and x-yell to be span and it rendered correctly.

Maybe this demo worked before the spec was changed to this behaviour.

@Pyrolistical
Copy link
Author

Nevermind. It does work. Its just that JS Bin didn't auto run the JS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant