-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(Menu, InternalMenu): unify components #3234
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this allows to control paddings separately.
this stores internalMenuPaddingY value in case internalMenu is deleted
This ensures compatibility with Menu.
This ensures compatibility with Menu.
This ensures compatibility with Menu.
This ensures compatibility with Menu.
…bkontur/retail-ui into IF-1310-Menu-InternalMenu-unification
zhzz
requested changes
Aug 10, 2023
zhzz
approved these changes
Aug 11, 2023
zhzz
pushed a commit
that referenced
this pull request
Aug 31, 2023
zhzz
pushed a commit
that referenced
this pull request
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Проблема
На данный момент у нас есть два очень похожих компонента:
Menu
иInternalMenu
. Эти компоненты процентов на 70% делят одну и ту же логику и почти вся новая логика, которая попадает в один компонент, тут же добавляется в другой. Но часть логики компонентов всё-таки различается, что может вызывать проблемы в самым неожиданных местах и заставляет нас иметь два похожих, но немного (или много) различающихся варианта логики.Решение
Ссылки
IF-1310 Menu, InternalMenu: унифицировать компоненты
Чек-лист перед запросом ревью
Добавлены тесты на все изменения
⬜ unit-тесты для логики
⬜ скриншоты для верстки и кросс-браузерности
✅ нерелевантно
Добавлена (обновлена) документация
⬜ styleguidist для пропов и примеров использования компонентов
✅ jsdoc для утилит и хелперов
⬜ комментарии для неочевидных мест в коде
⬜ прочие инструкции (
README.md
,contributing.md
и др.)✅ нерелевантно
Изменения корректно типизированы
✅ без использования
any
(см. PR2856
)⬜ нерелевантно
Прочее
✅ все тесты и линтеры на CI проходят
⬜ в коде нет лишних изменений
✅ заголовок PR кратко и доступно отражает суть изменений (он попадет в changelog)