feat(MenuHeader, MenuItem): add prop size, tests, documentation #3252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # packages/react-ui/.creevey/images/Baseline/Different fonts in large/chrome.png # packages/react-ui/.creevey/images/Baseline/Different fonts in large/chrome2022.png # packages/react-ui/.creevey/images/Baseline/Different fonts in large/chrome2022Dark.png # packages/react-ui/.creevey/images/Baseline/Different fonts in large/chrome8px.png # packages/react-ui/.creevey/images/Baseline/Different fonts in large/chromeDark.png # packages/react-ui/.creevey/images/Baseline/Different fonts in large/firefox.png # packages/react-ui/.creevey/images/Baseline/Different fonts in large/firefox2022.png # packages/react-ui/.creevey/images/Baseline/Different fonts in large/firefox2022Dark.png # packages/react-ui/.creevey/images/Baseline/Different fonts in large/firefox8px.png # packages/react-ui/.creevey/images/Baseline/Different fonts in large/firefoxDark.png # packages/react-ui/components/__stories__/baseline.stories.tsx
zhzz
requested changes
Aug 30, 2023
zhzz
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Проблема
Добавить проп size для MenuHeader, MenuItem
Ссылки
https://yt.skbkontur.ru/issue/IF-1358/Dobavit-prop-Size-dlya-Droplists-MenuItem-MenuHeader
https://yt.skbkontur.ru/issue/IF-807/Dobavit-propy-size-dlya-vseh-komponentov
Чек-лист перед запросом ревью
Добавлены тесты на все изменения
⬜ unit-тесты для логики
✅ скриншоты для верстки и кросс-браузерности
⬜ нерелевантно
Добавлена (обновлена) документация
✅ styleguidist для пропов и примеров использования компонентов
⬜ jsdoc для утилит и хелперов
⬜ комментарии для неочевидных мест в коде
⬜ прочие инструкции (
README.md,contributing.mdи др.)⬜ нерелевантно
Изменения корректно типизированы
✅ без использования
any(см. PR2856)⬜ нерелевантно
Прочее
✅ все тесты и линтеры на CI проходят
✅ в коде нет лишних изменений
✅ заголовок PR кратко и доступно отражает суть изменений (он попадет в changelog)