-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ComboBox): fix mobile overlay not closing when using public methods #3268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhzz
requested changes
Sep 19, 2023
…:skbkontur/retail-ui into IF-1225-mobileComboBox-not-fully-closing
zhzz
requested changes
Sep 20, 2023
packages/react-ui/components/ComboBox/__stories__/Combobox.stories.tsx
Outdated
Show resolved
Hide resolved
zhzz
requested changes
Oct 4, 2023
packages/react-ui/components/ComboBox/__tests__/ComboBox-test.tsx
Outdated
Show resolved
Hide resolved
packages/react-ui/components/ComboBox/__tests__/ComboBox-test.tsx
Outdated
Show resolved
Hide resolved
packages/react-ui/components/ComboBox/__tests__/ComboBox-test.tsx
Outdated
Show resolved
Hide resolved
zhzz
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Проблема
При использовании методов .reset() и/или .close() на мобилках Комбобокс закрывается не до конца.
Для мобилок используется компонент
<MobilePopup>
с собственным пропopened
.В компоненте
<ComboBoxView>
, который использует<MobilePopup>
, прокидывает в этот проп специальный флагstate.isMobileOpened
, который не синхронизирован с флагомprops.opened
.Решение
Я убрал из компонента
<ComboBoxView
состояние, отвечающее за отрисовку мобильного меню, и сделал отрисовку зависимой от пропаopened
, как в десктопной версии. Так же вынес методы открытия и закрытия мобильного меню в родительский компонентCustomComboBox
.Ссылки
fix IF-1225 ComboBox: не закрывается оверлей на мобилках при использовании публичных методов
Чек-лист перед запросом ревью
Добавлены тесты на все изменения
⬜ unit-тесты для логики
✅ скриншоты для верстки и кросс-браузерности
⬜ нерелевантно
Добавлена (обновлена) документация
⬜ styleguidist для пропов и примеров использования компонентов
⬜ jsdoc для утилит и хелперов
⬜ комментарии для неочевидных мест в коде
⬜ прочие инструкции (
README.md
,contributing.md
и др.)✅ нерелевантно
Изменения корректно типизированы
✅ без использования
any
(см. PR2856
)⬜ нерелевантно
Прочее
✅ все тесты и линтеры на CI проходят
✅ в коде нет лишних изменений
✅ заголовок PR кратко и доступно отражает суть изменений (он попадет в changelog)