Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There are incomplete shaders included which are non-functional and should be removed. #9

Open
skeletonbow opened this issue May 16, 2022 · 2 comments
Assignees
Labels
bad-practice BLOCKER Blocks the release of a new version of the software being released.

Comments

@skeletonbow
Copy link
Owner

Shaderfilter 1.21 comes with a handful of shaders which appear to have had development started on them but never finished so they are completely non-functional, which could confuse users trying to get them to work. Many months ago someone was trying to port all of the shaders to GLSL to get them working on Mac without being very experienced in such matters and a stumbling block they fell upon was some of these non-functional shaders.

These shaders should be completed or more likely just completely removed as they're non-functional. The software should only ship with working code. Development should occur in one branch and get merged to master only when it is functional and ready to be included.

This may not be a complete list but some of the shaders which are incomplete and non-functional include:

  • darken.shader

I'll complete the list as I go through them at a later date.

@skeletonbow skeletonbow added BLOCKER Blocks the release of a new version of the software being released. bad-practice labels May 16, 2022
@skeletonbow
Copy link
Owner Author

Removed darken.shader in SB-2.0-dev branch

@skeletonbow
Copy link
Owner Author

aspect_ratio.shader might be salvageable, otherwise remove it.

@skeletonbow skeletonbow self-assigned this May 18, 2022
@skeletonbow skeletonbow added this to the 2.0 Beta Test Release 1 milestone May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bad-practice BLOCKER Blocks the release of a new version of the software being released.
Projects
None yet
Development

No branches or pull requests

1 participant