Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement support for Skeleton v2 #37

Closed
9 tasks
endigo9740 opened this issue Aug 8, 2023 · 2 comments
Closed
9 tasks

Implement support for Skeleton v2 #37

endigo9740 opened this issue Aug 8, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request feature request Request a new feature or change

Comments

@endigo9740
Copy link
Contributor

endigo9740 commented Aug 8, 2023

With the v2 release candidate fast approaching (ETA august 15th), we'll need to update CSA to support all the various changes coming to the onboarding, setup, and configuration process for new Skeleton projects.

The most notable changes are in regards to the Tailwind plugin, themes, and stylesheets per @AdrianGonz97 migration guide. Note that our user-facing documentation has also been updated on the in-progress v2 pull request.

I would recommend reading through the following pages top-to-bottom to familiarize yourself with the incoming changes:

Here's a rough checklist of what this might entail:

  • Ensure the new Skeleton Tailwind plugin is installed on setup alongside the core package:
    • npm i -D @skeletonlabs/skeleton @skeletonlabs/tw-plugin
  • Ensure the four @tailwind directives are kept in app.postcss, rather than removed
  • We now have a choice between .cjs | .js | .ts for the tailwind.config.x file. (see comments for details)
  • We no longer append theme-x.css or skeleton.css to the root layout
  • Multiple changes in regards to themes:
    • Preset theme(s) are now registered within tailwind.config > Skeleton plugin > theme > preset
    • Custom theme(s) are now registered within tailwind.config > Skeleton plugin > theme > custom
    • The active theme is now set via the data-theme attribute on the body tag in app.html
    • Theme "extras" are now referred to as enhancements and set within the registered theme settings

(note that the list above may not be exhaustive, but should cover the most critical items)

@endigo9740
Copy link
Contributor Author

endigo9740 commented Aug 8, 2023

@AdrianGonz97 I would welcome a review of the list above, let me know if I missed anything here.

@niktek let us know if you need someone else to jump in and help implement. I'm sure Mahmoud or someone would be willing and able!

@endigo9740 endigo9740 added enhancement New feature or request feature request Request a new feature or change labels Aug 8, 2023
@AdrianGonz97
Copy link
Member

We now have a choice between .cjs | .js | .ts for the tailwind.config.x file. (prefer .cjs?)

We're going to want to prefer .js for the TW config. We can also have it change to a .ts file as well when the user selects TS, but it's not absolutely necessary if it's too much of a headache to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature request Request a new feature or change
Projects
None yet
Development

No branches or pull requests

3 participants