-
-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
<Step> is not a valid SSR component in SvelteKit #102
Comments
Ok, it got fixed, I had to manually import |
Hi @hshoob, thanks for reporting this issue. It looks like we've missed a couple export ins A couple things to note:
Modifying the contents of your
Even when |
See: #103 |
@endigo9740 thanks for the above. I totally agree it's bad to get things directly from Also, would be good to have a listbox similar to the tailwind headlessui listbox in Skeleton. If not anytime soon, can you propose an implementation with Skeleton, please? Thanks! |
Sounds good! I'd say keep an eye on the releases section on Skeleton and our social channels to know when that goes live. Twitter, Discord, etc. I see the value of what Tailwind is doing with the Listbox, but right now we're taking a pretty hard stance against replicating form input components that exist that already have a solid native equivalent. Read the text at the top of this page for a better explanation: I think you most folks would be better served using a native That said, we're building Skeleton for the community, not just for myself. So I welcome feedback like this. I'd highly encourage you view our roadmap and the discussion thread for it here. Chime in with this (or any other) suggestions you have. The team will be reviewing this soon and it'll help steer priority for us: Thanks! |
This is great, thanks, @endigo9740 !
I read that when I was going through the docs, and I totally agree. It's just that sometimes we all get tempted by custom styling. :) |
The Step component gives the below error:
Is there a way to SSR this? Below is the
package.json
:The
import { Step } from '@brainandbones/skeleton'
gives error, so I manually addedNavItem
component to/node_modules/@brainandbones/skeleton/index.d.ts
.The
import { NavItem } from '@brainandbones/skeleton'
also gives error, added it manually to bothindex.js
andindex.d.ts
in/node_modules/@brainandbones/skeleton/
.The text was updated successfully, but these errors were encountered: