Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button Groups Hover Effect outside the borders #1096

Closed
fabi-flex opened this issue Mar 5, 2023 · 6 comments · Fixed by #1113
Closed

Button Groups Hover Effect outside the borders #1096

fabi-flex opened this issue Mar 5, 2023 · 6 comments · Fixed by #1113
Labels
bug Something isn't working
Milestone

Comments

@fabi-flex
Copy link

Current Behavior

Docs > Tailwind > Buttons

If you have a theme with rounded buttons selected, the hover effect is visible outside the Borders.
You can see it in the picture below.

image

Steps To Reproduce

You can see it in the Documentation.

Anything else?

I am still completely new to programming, I'm sorry if I am using this IssueTool incorrectly.
I just noticed it and wanted to let you guys know.

Have a nice day! Thanks for the great work

@fabi-flex fabi-flex added the bug Something isn't working label Mar 5, 2023
@endigo9740 endigo9740 added this to the v1.0 milestone Mar 7, 2023
@ryceg
Copy link
Contributor

ryceg commented Mar 7, 2023

Hey @fabi-flex I'm trying to reproduce this and am having some troubles. Can you provide exact steps for replication?

@niktek
Copy link
Contributor

niktek commented Mar 7, 2023

Also be handy to know what OS, what browser and the steps for the theme setup - did you just select Crimson ? did you make your own selections on the Theme Generator ? Did you do this on the https://skeleton.dev version or on https://dev.skeleton.dev

@endigo9740
Copy link
Contributor

Likewise I've tried and failed to replicate this. We'll need more info, including a code sample to test.

@fabi-flex
Copy link
Author

I'm on this site: https://www.skeleton.dev/elements/buttons

System: Safari Version 16.3, Apple Macbook with M1

Yes, I selected the Crimson theme from the menu in the top right.
It also happens with the Sahara theme (I think every theme with rounded buttons).

The theme generator is not in the live preview mode.

@endigo9740
Copy link
Contributor

Thanks @fabi-flex, it's subtle on some of the other themes but I do see it now. It does look to be a Safari-specific issue, so I think that's the piece of the puzzle we were missing.

I'm not seeing it on our dev version of the library, but it's using a different variant here, which could be why. I'll look test the two other variants soon and reply back here with my findings:
https://dev.skeleton.dev/elements/buttons

@endigo9740
Copy link
Contributor

I've found the issue, it's actually one I've run into with Safari in the past:
https://stackoverflow.com/a/58283449

A fix has been put in place and this will come as part of the next release. This will resolve the issue for both the horizontal and vertical modes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants