Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tailwind v3.3 Updates #1238

Closed
endigo9740 opened this issue Mar 30, 2023 · 4 comments
Closed

Tailwind v3.3 Updates #1238

endigo9740 opened this issue Mar 30, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request feature request Request a feature or introduce and update to the project.

Comments

@endigo9740
Copy link
Contributor

endigo9740 commented Mar 30, 2023

https://tailwindcss.com/blog/tailwindcss-v3-3

Now that Tailwind v3.3 is live we should look test and ensure Skeleton is working as expected with our default instructions and CLI, while also implementing a number of quality of life improvements. Especially the new Typescript based config file. I'll note each potential change below, which should be split into it's own ticket:

NOTE: the list below has been created with the highest priority items first.

Regression Testing

Ensure updating to v3.3 with no other modifications works as expected, with no notable regressions.

April 4th: initial testing in the first couple days are promising. No notable issues. Feel free to update, but be cautious!

Type Support for Config File - Info

One of the most error prone parts of using Tailwind is the config file due to the lack of IntelliSense or feedback when a mistake is made in the config file. So we should aim to embrace this new format and the benefits it provides asap. This should cut down a slew of support issues on our end.

NOTE: we may need to contact Svelte-Add to request they setup the config file in this format.

Extended Color Palette - Info

This provides a new 950 shade for darker darks. With this change there are now 11 total color shades available, which means shade 500 is now the true middle tone. The theme generator, design tokens, general documentation, and our preset themes should all be updated to better account for this change. This seems like a trivial change, but will be far reaching.

Line Clamp Built In - Info

Now that the plugin can be retired, we should update our docs and especially the CLI to exclude this plugin recommendation.

Gradient Stop Positions - Info

In addition to finer control of gradient stops, this now has a direct benefit to the Conic Gradient component. By implementing a conic gradient into our Skeleton Tailwind plugin modules, we can now support conic gradients declared entirely with Tailwind - no JS involved! Note that this will likely fall under the category of a breaking change though.

CSS variables without the var() - Info

We should update our Docs > Essentials > Styling page to reflect this new option. It's very handy!

New list-style-image utilities - Info

We may want to update our list styles and listbox to support this, with examples.

New caption-side utilities - Info

There's a number of places we might implement this, such our Table styles, as well as our own blog! Ghost allows for captions for most types of embeds.

@endigo9740 endigo9740 added enhancement New feature or request feature request Request a feature or introduce and update to the project. labels Mar 30, 2023
@endigo9740 endigo9740 added this to the Future/Whenever milestone Mar 30, 2023
@endigo9740 endigo9740 pinned this issue Mar 30, 2023
@avarun42
Copy link

avarun42 commented Apr 4, 2023

What's the canonical way to set up Skeleton in a tailwind.config.ts now that ESM and TS config file support is out?

@endigo9740
Copy link
Contributor Author

@avarun42 you posted in a ticket with the first two items listed above being:

  1. Regression test Tailwind v3.3 and...
  2. Test the new config format

So short answer is we don't know yet. Continue follow the current docs if that works without issue, otherwise post your issues here. We'll share instructions once we've got to that point.

@endigo9740 endigo9740 unpinned this issue Apr 21, 2023
@endigo9740 endigo9740 pinned this issue May 8, 2023
@endigo9740 endigo9740 unpinned this issue May 15, 2023
@endigo9740 endigo9740 modified the milestones: Future/Whenever, v3.0 Jun 2, 2023
@endigo9740 endigo9740 added the help wanted Extra attention is needed label Jun 2, 2023
@endigo9740
Copy link
Contributor Author

See me if you wish to work on some of these items. They'll need their own dedicated task per each issue. Some items require perquisite work as well.

@endigo9740 endigo9740 removed the help wanted Extra attention is needed label Jun 14, 2023
@endigo9740
Copy link
Contributor Author

With v2 we've addressed the most pressing of the issues above. The upcoming theme generator rework will go a bit further though, such as extending the palette. Given this, we'll go ahead and sunset this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature request Request a feature or introduce and update to the project.
Projects
None yet
Development

No branches or pull requests

3 participants