Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox: Modal with a single button can't be tabbed in #1591

Closed
Mahmoud-zino opened this issue May 29, 2023 · 5 comments
Closed

Firefox: Modal with a single button can't be tabbed in #1591

Mahmoud-zino opened this issue May 29, 2023 · 5 comments
Labels
bug Something isn't working help wanted Extra attention is needed
Milestone

Comments

@Mahmoud-zino
Copy link
Sponsor Contributor

Mahmoud-zino commented May 29, 2023

Current Behavior

Firefox: if there is only one button even after tabbing it won't show the focus style however when there are multiple buttons tabbing will display the focus style correctly.

Expected Behavior

tabbing should display the focused style even if there is only one button.

Steps To Reproduce

  1. Navigate to Skeleton - Modals
  2. click on the first "Show Modal"
  3. tabbing won't change the style but clicking in the region of the button and then tabbing will display the correct style.
  4. On the other hand, if you click on the "Confirm Modal" example which has two buttons, tabbing will work as expected.

Link to Reproduction / Stackblitz

No response

More Information

No response

@Mahmoud-zino Mahmoud-zino added the bug Something isn't working label May 29, 2023
@Mahmoud-zino Mahmoud-zino changed the title Button focus style at initialization Firefox: Modal with a single button can't be tabbed in Jun 2, 2023
@endigo9740 endigo9740 added the help wanted Extra attention is needed label Jun 2, 2023
@endigo9740
Copy link
Contributor

FYI This appears to be limited to Firefox. On Chrome this behaves as expected.

@aaroncrockett
Copy link
Contributor

I would be happy to work on this issue.

@Sarenor Sarenor assigned Sarenor and aaroncrockett and unassigned Sarenor Sep 16, 2023
@Sarenor
Copy link
Contributor

Sarenor commented Sep 16, 2023

@aaronmichaelhappe after an accidental oopsie: I assigned the issue to you.
Usually we ask people to open an early draft pr as soon as possible to mark it as "definitely being worked on", but seeing as this is probably mostly a debugging thing: Just keep us up to date?

@aaroncrockett
Copy link
Contributor

@Sarenor sure thing. I am aaronmichaelhappe on the discord server if you need to reach out and will keep you up to date.

@endigo9740
Copy link
Contributor

In an effort to prepare for Skeleton v3, we're consolidate some related issues down to a single ticket. This will ensure that we can see the full context of requests when the time comes to refactor and update this feature going forward. If you wish to add additional feedback or suggestions, please so here:

@endigo9740 endigo9740 modified the milestones: v3.0 (Next), v2.0 Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants