Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Svelte 4 a11y warnings #1708

Closed
AdrianGonz97 opened this issue Jun 30, 2023 · 6 comments
Closed

Fix Svelte 4 a11y warnings #1708

AdrianGonz97 opened this issue Jun 30, 2023 · 6 comments
Labels
bug Something isn't working

Comments

@AdrianGonz97
Copy link
Member

Current Behavior

These are denoted with a TODO: Remove for V2 tag so that they may be easily searchable.

Expected Behavior

No response

Steps To Reproduce

No response

Link to Reproduction / Stackblitz

No response

More Information

No response

@AdrianGonz97 AdrianGonz97 added the bug Something isn't working label Jun 30, 2023
@endigo9740 endigo9740 added this to the v2.0 milestone Jun 30, 2023
@endigo9740 endigo9740 pinned this issue Jun 30, 2023
@Mahmoud-zino
Copy link
Sponsor Contributor

Since the AppRailTile has also an issue with a11y, It could be a good opportunity to refactor it and implement keyboard support.

@ollema
Copy link

ollema commented Jul 4, 2023

Just wanted to mention that I believe that one of the warnings was not silenced:

7:06:18 PM [vite-plugin-svelte] /node_modules/.pnpm/@skeletonlabs+skeleton@1.9.0_svelte@4.0.3/node_modules/@skeletonlabs/skeleton/dist/components/Ratings/Ratings.svelte:29:3 A11y: <svelte:element> with click handler must have an ARIA role

Maybe this was known?

@Mahmoud-zino
Copy link
Sponsor Contributor

I would like to work on this issue 🙏.

@endigo9740
Copy link
Contributor

endigo9740 commented Jul 10, 2023

@Mahmoud-zino I might have you help me with one, but I really need to be hands on for anything a11y related. There's a lot of rules and we've gotta make sure changes are implemented in a very specific manner. In this case I know we'll be refactoring a number of components, but I don't know the specifics needed. Each will be determined on a case-by-case basis - even though we might end up making similar changes in multiple places.

I'll try to ping you when I circle back to this though. Thanks!

@endigo9740 endigo9740 unpinned this issue Aug 4, 2023
@endigo9740 endigo9740 pinned this issue Aug 4, 2023
@endigo9740 endigo9740 self-assigned this Aug 4, 2023
@endigo9740 endigo9740 unpinned this issue Aug 21, 2023
@endigo9740 endigo9740 modified the milestones: v2.0, Future/Whenever Aug 21, 2023
@endigo9740 endigo9740 removed their assignment Aug 29, 2023
@endigo9740
Copy link
Contributor

endigo9740 commented Sep 8, 2023

Let's review these specific changes alongside addressing the a11y concerns:

@endigo9740
Copy link
Contributor

endigo9740 commented Dec 19, 2023

I'm closing this as we will likely not have time to fix this in v2, and v3 will includes rewrites as we port to Svelte 5. Most, if not all, of these issues should be handled along the way. This means this issue is no longer relevant to active tasks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants