Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2 Support for Theme Generator #1781

Closed
endigo9740 opened this issue Jul 19, 2023 · 0 comments
Closed

v2 Support for Theme Generator #1781

endigo9740 opened this issue Jul 19, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request feature request Request a feature or introduce and update to the project.

Comments

@endigo9740
Copy link
Contributor

endigo9740 commented Jul 19, 2023

As part of @AdrianGonz97's recent rework to the Tailwind plugin for Skeleton v2, these are now defined in CSS-in-JS format as opposed to pure CSS.

Task 1: Update the Theme Generator

This provides a number of befits, however we'll need to update the Theme Generator to output new themes in this format by default. An example of the new format is provided below.

// my-custom-theme.ts

export const myCustomTheme = {
    name: 'custom-theme-name',
    properties: {
        // paste your custom theme properties here...

        // for example:
        "--theme-font-family-base": "system-ui, sans-serif",
        "--theme-font-family-heading": "'Quicksand', sans-serif",
        "--theme-font-color-base": "var(--color-surface-900)",
        "--theme-font-color-dark": "var(--color-surface-50)"
        // ... and so on
    }
};
// tailwind.config.[cjs|js|ts]

import myCustomTheme from './my-custom-theme'

plugins: [
    skeleton({
        themes: {
            custom: [
                myCustomTheme
            ]
        }
    })
]

Task 2: Update Theme Documentation

Given the number of changes, we need to update the /docs/themes documentation section to reflect the latest state of changes for v2. Most of this can be based around the migration info provided in this thread.

@endigo9740 endigo9740 added enhancement New feature or request feature request Request a feature or introduce and update to the project. labels Jul 19, 2023
@endigo9740 endigo9740 self-assigned this Jul 19, 2023
@endigo9740 endigo9740 pinned this issue Jul 19, 2023
@endigo9740 endigo9740 changed the title v2 Support for Theme Generator CLOSED: v2 Support for Theme Generator Aug 2, 2023
@endigo9740 endigo9740 changed the title CLOSED: v2 Support for Theme Generator v2 Support for Theme Generator Aug 2, 2023
@endigo9740 endigo9740 unpinned this issue Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature request Request a feature or introduce and update to the project.
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant