Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree-view recursive-mode events bug #1943

Closed
Mahmoud-zino opened this issue Aug 25, 2023 · 1 comment · Fixed by #2069
Closed

Tree-view recursive-mode events bug #1943

Mahmoud-zino opened this issue Aug 25, 2023 · 1 comment · Fixed by #2069
Assignees
Labels
bug Something isn't working

Comments

@Mahmoud-zino
Copy link
Sponsor Contributor

Current Behavior

there are tow issues related to events at the moment:

  1. Unless a change also changes it's parents value the bind value does not trigger an update (reactivity).
  2. clicking on a node with no children will trigger reactivity (the value of node's open prop is changing even if it doesn't have children)

Expected Behavior

  1. every change on the nodes object should trigger reactivity.
  2. only nodes with children should trigger reactivity (if opened/closed)

Steps To Reproduce

No response

Link to Reproduction / Stackblitz

No response

More Information

reported in https://discord.com/channels/1003691521280856084/1144130943527956510

@Mahmoud-zino Mahmoud-zino added the bug Something isn't working label Aug 25, 2023
@Sarenor
Copy link
Contributor

Sarenor commented Aug 27, 2023

Just as a node: When you do start refactoring the TreeView and adding tests to it, you might want to consider splitting it in 2 separate components for datadriven & manual mode for ease of use and testing.
Might help in reducing complexity :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants