Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differentiate between Modal Props and ModalSetting attributes in props tab #2120

Closed
Sarenor opened this issue Oct 5, 2023 · 1 comment · Fixed by #2122
Closed

Differentiate between Modal Props and ModalSetting attributes in props tab #2120

Sarenor opened this issue Oct 5, 2023 · 1 comment · Fixed by #2122
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@Sarenor
Copy link
Contributor

Sarenor commented Oct 5, 2023

Link to the Page

https://www.skeleton.dev/utilities/modals

Describe the Issue (screenshots encouraged!)

People keep trying to mix them interchangeably because they are part of the same list.
We should consider ways to split them without breaking out of the docs shell to much.

I volunteer, mostly because it's been bugging me for a while now :)

@Sarenor Sarenor added the documentation Improvements or additions to documentation label Oct 5, 2023
@Sarenor Sarenor self-assigned this Oct 5, 2023
@Sarenor
Copy link
Contributor Author

Sarenor commented Oct 5, 2023

Seems like it's a bit of a problem with the ModalSettings just being ignored since we fill the Props page just with the Sveld-Data.
Probably going to take this to #Contributors on Discord to discuss potential fixes.

@endigo9740 endigo9740 linked a pull request Oct 6, 2023 that will close this issue
7 tasks
@endigo9740 endigo9740 mentioned this issue Oct 6, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant