Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Svelte v5 RC: Theme Generator live previews are non-functional #2641

Closed
endigo9740 opened this issue Apr 30, 2024 · 1 comment
Closed

Svelte v5 RC: Theme Generator live previews are non-functional #2641

endigo9740 opened this issue Apr 30, 2024 · 1 comment
Assignees
Labels
bug Something isn't working documentation Improvements or additions to documentation
Milestone

Comments

@endigo9740
Copy link
Contributor

Link to the Page

https://www.skeleton.dev/docs/generator

Describe the Issue (screenshots encouraged!)

While testing the Svelte v5 RC, I noticed the theme generator itself is loading. But live previews are not. I believe the issue may be related to how we're implementing the <style> tag in the <svelte:head>.

How to Test

We can temporarily migrate to the Svelte v5 RC package while working on the PR:

pnpm i -D svelte@next

We will need to take care to revert this change before merging into the dev branch.

@endigo9740 endigo9740 added bug Something isn't working documentation Improvements or additions to documentation labels Apr 30, 2024
@endigo9740 endigo9740 added this to the v2.0 milestone Apr 30, 2024
@endigo9740 endigo9740 changed the title Svelte v5 RC: Theme Generator is non-functional Svelte v5 RC: Theme Generator live previews are non-functional Apr 30, 2024
@endigo9740
Copy link
Contributor Author

We wont' be migrating the v2 docs to Svelte v5 so we'll dub this a non-issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants