Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional a11y warnings to resolve #2662

Closed
endigo9740 opened this issue May 15, 2024 · 0 comments · Fixed by #2716
Closed

Additional a11y warnings to resolve #2662

endigo9740 opened this issue May 15, 2024 · 0 comments · Fixed by #2716
Labels
bug Something isn't working
Milestone

Comments

@endigo9740
Copy link
Contributor

Current Behavior

We recently updated a number of components to silence a11y warnings provided in newer versions of Svelte. Most errors have been resolved, but it looks like we missed on for the AppRailAnchor

Screenshot 2024-05-15 at 9 22 00 AM

Expected Behavior

The error is due to the slew of events forwarded here:

https://github.com/skeletonlabs/skeleton/blob/master/packages/skeleton/src/lib/components/AppRail/AppRailAnchor.svelte#L53

We should either:

  1. Remove the extraneous events
  2. Set a proper aria role (per the error) - best guess would be button off-hand

Steps To Reproduce

The errors appear when starting a Skeleton app. Regardless if you use the AppRailAnchor or not.

Link to Reproduction / Stackblitz

No response

More Information

Please consult with me before making this change. We need to decided between the two options provided above.

@endigo9740 endigo9740 added the bug Something isn't working label May 15, 2024
@endigo9740 endigo9740 added this to the v2.0 milestone May 15, 2024
@endigo9740 endigo9740 pinned this issue May 15, 2024
@endigo9740 endigo9740 linked a pull request Jun 7, 2024 that will close this issue
7 tasks
@endigo9740 endigo9740 unpinned this issue Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant