Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the Design Token system #553

Closed
5 tasks done
endigo9740 opened this issue Nov 15, 2022 · 4 comments · Fixed by #638
Closed
5 tasks done

Improve the Design Token system #553

endigo9740 opened this issue Nov 15, 2022 · 4 comments · Fixed by #638
Assignees
Labels
enhancement New feature or request feature request Request a feature or introduce and update to the project. ready to test Ready to be tested for quality assurance.
Milestone

Comments

@endigo9740
Copy link
Contributor

endigo9740 commented Nov 15, 2022

Describe what feature you'd like. Pseudo-code, mockups, or screenshots of similar solutions are encouraged!

The initial draft of the design token system has been a huge hit and very well received. However, we would stand to make some significant improvements to make it even better.

This includes, but is not limited to the following:

  • Split the tokens into smaller stylesheets, similar to Tailwind Elements, for better organization
  • a11y: Introduce a new on-{x} color system for text and icon fill colors when overlaid in buttons, etc
  • Update theme generator to support on-{x} properties
  • Flush out the tokens that already exist, ensure there are no gaps
  • Improve the documentation page, provide better examples.

What type of pull request would this be?

Enhancement

Any links to similar examples or other references we should review?

Material Design has some references we can follow:

This may be one of the final updates required to close out:

@endigo9740 endigo9740 added the feature request Request a feature or introduce and update to the project. label Nov 15, 2022
@endigo9740 endigo9740 self-assigned this Nov 15, 2022
@endigo9740 endigo9740 added the enhancement New feature or request label Nov 15, 2022
@endigo9740 endigo9740 pinned this issue Nov 15, 2022
@endigo9740 endigo9740 added this to the v1.0 milestone Nov 15, 2022
@endigo9740 endigo9740 changed the title Improvements to the Design Token system Improve the Design Token system Nov 15, 2022
@endigo9740 endigo9740 linked a pull request Dec 5, 2022 that will close this issue
@endigo9740
Copy link
Contributor Author

NOTE: I have modified the accent and background props on the AppRail and Tile to be active and hover respectively. This better matches the new token values.

@endigo9740
Copy link
Contributor Author

NOTE: .card-body has been dropped in favor of p-4. .card-header|body remain.

@endigo9740
Copy link
Contributor Author

I've got MOST existing styles flushed out, just need to run through and documented. I think we should handle applying these to various elements and components in a dedicated pass. Either at the tail end of this PR or separate one.

@endigo9740 endigo9740 added the ready to test Ready to be tested for quality assurance. label Dec 7, 2022
@endigo9740
Copy link
Contributor Author

endigo9740 commented Dec 7, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature request Request a feature or introduce and update to the project. ready to test Ready to be tested for quality assurance.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant